This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Add v128 to JS API #360
Merged
Add v128 to JS API #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the description given in https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#javascript-api-and-simd-values and also what I64 did before bigint integration.
dtig
reviewed
Jan 5, 2021
| @@ -1039,6 +1054,7 @@ Note: Exported Functions do not have a \[[Construct]] method and thus it is not | |||
| <div algorithm> | |||
| The algorithm <dfn>ToJSValue</dfn>(|w|) coerces a [=WebAssembly value=] to a JavaScript value by performing the following steps: | |||
|
|
|||
| 1. Assert: |w| is not of the form [=v128.const=] <var ignore>v128</var>. | |||
There was a problem hiding this comment.
Perhaps I'm not understanding this well, why is this assert required? Also, what happens for i64 values without BigInt support?
There was a problem hiding this comment.
why is this assert required?
This assert is to ensure that we never call ToJSValue with a v128.const, since we don't know how to convert it to JS. In all the callers of ToJSValue we should have checked for v128 and raise an exception prior.
Also, what happens for i64 values without BigInt support?
I think BigInt support is required, not too sure.
dtig
approved these changes
Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the description given in
https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#javascript-api-and-simd-values
and also what I64 did before bigint integration.
js-api tests are not updated yet, that will come in a future patch.